Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs/eventtailer): use right tag for image #178

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ralgozino
Copy link
Member

@ralgozino ralgozino commented Nov 22, 2024

Since switching to images from kube-logging instead of the ones from Banzai Cloud, upstream image tags don't have the v in front anymore:

https://github.com/kube-logging/eventrouter/pkgs/container/eventrouter/118063456?tag=0.4.0
(upstream taken from our image-sync repository)

Ref:

Since swtiching to images from kube-logging instead of the ones from
banzai cloud, image tags don't have the `v` in front anymore:
https://github.com/kube-logging/eventrouter/pkgs/container/eventrouter/118063456?tag=0.4.0

(Upstream taken from our image-sync repository)
@ralgozino ralgozino self-assigned this Nov 22, 2024
@ralgozino ralgozino added the bug Something isn't working label Nov 22, 2024
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, but I'm not sure why I didn't catch it while testing logging

@ralgozino
Copy link
Member Author

I guess because in our registry somehow the image is also present with the v in the tag. My theory is it was manually tagged to fix this very issue after release.

I noticed because the image was not tagged with the v for ARM architecture (but is present without the v).

@ralgozino ralgozino merged commit 806823e into feat/release-3.5.0 Nov 22, 2024
2 checks passed
@ralgozino ralgozino deleted the fix-eventrouter-image-tag branch December 6, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants