Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spot instance creation when create node group using launch template #67

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Fix spot instance creation when create node group using launch template #67

merged 2 commits into from
Jul 11, 2023

Conversation

g-iannelli
Copy link
Contributor

@g-iannelli g-iannelli commented Jul 11, 2023 •
edited
Loading

add on launch template:

  • market_type
  • update_default_version
  • fix spot instance price

nutellinoit
nutellinoit approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nutellinoit nutellinoit merged commit 287b579 into main Jul 11, 2023
@omissis omissis deleted the fix/238-fix-spot-instance-behaviour branch July 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutellinoit nutellinoit nutellinoit approved these changes

@omissis omissis Awaiting requested review from omissis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-iannelli @nutellinoit