ENG-4971: Extending client object creation to support either a full U… #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklein0
reviewed
Apr 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 23.22% 22.69% -0.54%
==========================================
Files 11 11
Lines 1369 1397 +28
Branches 321 330 +9
==========================================
- Hits 318 317 -1
- Misses 1051 1080 +29 ☔ View full report in Codecov by Sentry. |
mklein0
requested changes
Apr 23, 2024
mklein0
reviewed
Apr 24, 2024
mklein0
reviewed
Apr 24, 2024
JMkrish
force-pushed
the
ENG-4971
branch
2 times, most recently
from
b5b3b3e to
908c397
Compare
mklein0
approved these changes
Apr 25, 2024
mklein0
requested changes
Apr 25, 2024
mklein0
reviewed
Apr 30, 2024
1) Added port to specify port in the URL. 2) Asserting after login returns.
mklein0
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIra: https://sightmachine.atlassian.net/browse/ENG-4971
This updates the creation process of client objects in the Sight Machine platform, expanding it to accept both full URLs and tenant names. Previously, client objects could only be initialized with tenant names. Now, users have the option to provide either a full URL (e.g., "https://demo.sightmachine.io/") or a simple tenant name (e.g., "demo").