Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4849:get_machine_names doesn't error if machine type doesn't exist #74

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

JMkrish
Copy link
Contributor

@JMkrish JMkrish commented Mar 18, 2024

Link to Jira: https://sightmachine.atlassian.net/browse/ENG-4849

get_machine_types API is modified to utilize utilize both source_type and source_type_clean for filtering the data.

smsdk/client.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.22%. Comparing base (54f2484) to head (1c6a8dd).

Files Patch % Lines
smsdk/client.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   23.25%   23.22%   -0.04%     
==========================================
  Files          11       11              
  Lines        1363     1365       +2     
  Branches      320      321       +1     
==========================================
  Hits          317      317              
- Misses       1046     1048       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JMkrish JMkrish merged commit 6521997 into master Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants