Addressing some more review comments. Trying to fix the codecove issue

.circleci/config.yml

@@ -126,7 +126,9 @@ jobs:
             pip install -r requirements-codecoverage.txt
             pip install .
             mkdir test-results
-            coverage run -m pytest -vvv --nbmake --nbmake-timeout=300 -n=auto --junitxml=test-results/junit.xml tests
+            # coverage run -m pytest -vvv --nbmake --nbmake-timeout=300 -n=auto --junitxml=test-results/junit.xml tests
+            coverage run -m pytest -vvv -n=auto --junitxml=test-results/junit.xml tests
+
       - run:
           name: Compile Coverage Report
           command: |

tests/Uri/test_uri.py

@@ -3,7 +3,7 @@
 from smsdk.utils import get_url
 
 
-def test_uri() -> None:
+def test_create_client_using_tenant() -> None:
     tenant: str = ""
     cli: client.Client = client.Client(tenant)
 
@@ -18,13 +18,43 @@ def test_uri() -> None:
     assert cli.config["protocol"] == "https"
     assert cli.config["site.domain"] == "sightmachine.io"
 
+    cli = client.Client(tenant, protocol="http")
+
+    assert cli.tenant == "demo"
+    assert cli.config["protocol"] == "http"
+    assert cli.config["site.domain"] == "sightmachine.io"
+
+    cli = client.Client(tenant, site_domain="localnet")
+
+    assert cli.tenant == "demo"
+    assert cli.config["protocol"] == "https"
+    assert cli.config["site.domain"] == "localnet"
+
+
+def test_create_client_using_uri() -> None:
     tenant = "demo-sdk-test.localnet"
     cli = client.Client(tenant)
 
     assert cli.tenant == "demo-sdk-test"
     assert cli.config["protocol"] == "https"
     assert cli.config["site.domain"] == "localnet"
 
+    tenant = "https://demo-sdk-test.localnet"
+    cli = client.Client(tenant)
+
+    assert cli.tenant == "demo-sdk-test"
+    assert cli.config["protocol"] == "https"
+    assert cli.config["site.domain"] == "localnet"
+
+    tenant = "http://demo-sdk-test.localnet:8080/"
+    cli = client.Client(tenant)
+
+    assert cli.tenant == "demo-sdk-test"
+    assert cli.config["protocol"] == "http"
+    assert cli.config["site.domain"] == "localnet"
+
+
+def test_create_client_uri_special_cases() -> None:
     tenant = "://demo-sdk-test.localnet"
     cli = client.Client(tenant)
 
@@ -39,18 +69,16 @@ def test_uri() -> None:
     assert cli.config["protocol"] == "http"
     assert cli.config["site.domain"] == "sightmachine.io"
 
-    tenant = "https://demo-sdk-test.localnet"
+    tenant = "demo-sdk-test.localnet:8080"
     cli = client.Client(tenant)
 
     assert cli.tenant == "demo-sdk-test"
     assert cli.config["protocol"] == "https"
     assert cli.config["site.domain"] == "localnet"
 
-    cli = client.Client("http://demo-sdk-test.localnet:8080/")
-
-    tenant = "http://demo-sdk-test.localnet:8080/"
+    tenant = "://demo-sdk-test.localnet:8080"
     cli = client.Client(tenant)
 
     assert cli.tenant == "demo-sdk-test"
-    assert cli.config["protocol"] == "http"
+    assert cli.config["protocol"] == "https"
     assert cli.config["site.domain"] == "localnet"