Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache license headers to new files #321

Open
wants to merge 1 commit into
base: freedom-metal-next
Choose a base branch
from

Conversation

keith-packard
Copy link
Contributor

Signed-off-by: Keith Packard keithp@keithp.com

Signed-off-by: Keith Packard <keithp@keithp.com>
@sifive-eblot
Copy link
Contributor

Is it worth adding the full license text if the SPDX line is defined?
We have the same question for scl-metal.

@keith-packard
Copy link
Contributor Author

Is it worth adding the full license text if the SPDX line is defined?

Yes, the SPDX line is not really sufficient to describe the license as
it depends on an external (non-SiFive) entity providing that
information.

I've been advised by lawyers at other companies to stick the license
header in each file to ensure the license is legally bound to the
file.

We have the same question for scl-metal.

I'd encourage you to follow the same practice; it's a minor
inconvenience when creating a new file, but doesn't really have any
significant impact for ongoing development.

@sifive-eblot
Copy link
Contributor

I'd encourage you to follow the same practice

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants