Refine Makefile.am and Makefile.in #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two trap.S in the list, if we use '-Wl,--whole-archive' to link libmetal.a, it causes the error of multiple definition. Signed-off-by: Zong Li <zong.li@sifive.com> Reported-by: Jerry Shih <jerry.shih@sifive.com>
zongbox
pushed a commit
that referenced
this pull request
Jun 14, 2021
Add make target to open local documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two trap.S in the list, if we use '-Wl,--whole-archive' to link libmetal.a, it causes the error of multiple definition.
The error messages as follows:
/scratch/zongl/toolchain/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /scratch/zongl/tmp/freedom-e-sdk/bsp/freedom-e31
0-arty/install/lib/debug//libmetal.a(trap.o): in function
.L0 ': /scratch/zongl/tmp/freedom-e-sdk/freedom-metal/src/trap.S:20: multiple definition of_metal_trap'; /scratch/zongl/tmp/freedom-e-sdk/bsp/freedom-e310-arty/install/lib/debug//libmetal.a(trap.o):/scratch/zongl/tmp/freedom-e-sdk/freedom-metal/src/trap.S:20: first defined here
/scratch/zongl/toolchain/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /scratch/zongl/tmp/freedom-e-sdk/bsp/freedom-e31
0-arty/install/lib/debug//libmetal.a(trap.o): in function
.L0 ': /scratch/zongl/tmp/freedom-e-sdk/freedom-metal/src/trap.S:64: multiple definition ofearly_trap_vector'; /scratch/zongl/tmp/freedom-e-sdk/bsp/freedom-e310-arty/install/lib/debug//libmetal.a(trap.o):/scratch/zongl/tmp/freedom-e-sdk/freedom-metal/src/trap.S:64: first defined here