-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sifive PWM. #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NandkumarJoshi
requested review from
bsousi5 and
nategraff-sifive
as code owners
March 14, 2020 04:58
NandkumarJoshi
force-pushed
the
sifive-pwm
branch
from
March 16, 2020 21:50
e34cd58
to
e6fe403
Compare
bsousi5
reviewed
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments to address
GPIO IOF register fix.
NandkumarJoshi
force-pushed
the
sifive-pwm
branch
from
March 17, 2020 17:18
e6fe403
to
0680185
Compare
bsousi5
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
bsousi5
pushed a commit
that referenced
this pull request
Apr 8, 2020
Allow Python >= 2.7 for elf2hex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added files for PWM driver. Minor updates to I2C. GPIO pin mux handling is changed, will affect pin mux values specified in dts. Current IO mux handling doesn't allow to 'set' a bit in 'IOF_SEL' register.
Fixed comments raised on previous PR, #206 .
PWM API is fairly generic, with support for :