Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sifive PWM. #232

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Add support for Sifive PWM. #232

merged 3 commits into from
Mar 19, 2020

Conversation

NandkumarJoshi
Copy link
Contributor

Added files for PWM driver. Minor updates to I2C. GPIO pin mux handling is changed, will affect pin mux values specified in dts. Current IO mux handling doesn't allow to 'set' a bit in 'IOF_SEL' register.
Fixed comments raised on previous PR, #206 .
PWM API is fairly generic, with support for :

  1. enable/disable pwm
  2. get/set freq
  3. get/set duty
  4. trigger in one shot / continuous mode
  5. stop pwm
  6. interrupt handling

Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments to address

metal/drivers/sifive_pwm0.h Outdated Show resolved Hide resolved
metal/pwm.h Outdated Show resolved Hide resolved
metal/pwm.h Show resolved Hide resolved
src/drivers/sifive_pwm0.c Outdated Show resolved Hide resolved
src/drivers/sifive_pwm0.c Show resolved Hide resolved
src/drivers/sifive_pwm0.c Show resolved Hide resolved
src/pwm.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@bsousi5 bsousi5 merged commit f2581d1 into master Mar 19, 2020
@bsousi5 bsousi5 deleted the sifive-pwm branch March 19, 2020 04:46
bsousi5 pushed a commit that referenced this pull request Apr 8, 2020
Allow Python >= 2.7 for elf2hex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants