Add macro & inline for get/set CSR #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This API will increasing 322 bytes on rv32ic or rv64ic with -Os for csr.c, and might be bigger once we fill up all supported CSR. Just reminder the code size cost is high and might hard to optimize/reduce that in future. |
|
Maybe the switch-case version should be removed from the API for code size in favor of just the macro. |
nategraff-sifive
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add two types of APIs, an inline function and a macro for get and set CSR registers.
The inline function is not fully fill yet, but will get fill up with all supported CSR listed in https://github.com/riscv/riscv-opcodes. Its purpose is to provide some prior check before calling.
The macro is intended to be a raw form of CSR set/get.