-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ux description for textarea #1520
base: feat/select-validation
Are you sure you want to change the base?
Conversation
|
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
- **Show text as tooltip**: [See form field](./forms/forms-field.md) | ||
- **Placeholder text**: [See form field](./forms/forms-field.md) | ||
- **Counter**: [See form field](./forms/forms-field.md) | ||
- **Resize behavior**: Determines how textareas can be resized (both directions, horizontally, vertically, no resizing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include: what is the standard size, what is our default version, and when do we use each option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, is this an option or should it be handled in the behavior in context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to have a short notice on resizing options (both, horiz, vert, none) here and guidance how to use it in the behavior section.
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
- Do use the textarea for inputs that require multiple lines of text, such as comments, feedback, or detailed descriptions | ||
- Do ensure the textarea is appropriately sized for the expected input | ||
- Do use the placeholder attribute to give users an example of the expected input | ||
- Do use minimum and maximum character limits to handle edge cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do set minimum and maximum character limits to ensure proper input length
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
![Textarea overview](https://www.figma.com/design/wEptRgAezDU1z80Cn3eZ0o/iX-Pattern-Illustrations?node-id=3814-1128&t=DtCmoFcLwhf7ke3S-4) | ||
1. Label | ||
2. Required field indicator (optional) | ||
3. Placeholder text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only "Placeholder"
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
🆕 What is the new behavior?
New UX description for textarea
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support