Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/upload): disable file browser if control is disabled #1506

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

danielleroux
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: Closes #1276

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 662999d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/core/src/components/upload/test/upload.ct.ts Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/core/src/tests/utils/test/page.ts Outdated Show resolved Hide resolved
packages/core/src/components/upload/upload.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 10, 2024

@danielleroux danielleroux merged commit 393b51d into main Oct 10, 2024
15 checks passed
@danielleroux danielleroux deleted the fix/1226-upload-disabled branch October 10, 2024 11:06
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IxUpload] disabled and LOADING don't prevent opening the dialog with keyboard
2 participants