Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(strict-check): add tsconfig strict check to pull requests #1494

Merged
merged 14 commits into from
Oct 1, 2024

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Sep 24, 2024

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: e26c707

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danielleroux danielleroux changed the title Sonar ts config test ci(strict-check): add tsconfig strict check to pull requests Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

@danielleroux danielleroux marked this pull request as ready for review September 25, 2024 08:26
@danielleroux danielleroux merged commit 99f35e1 into main Oct 1, 2024
15 checks passed
@danielleroux danielleroux deleted the sonar-ts-config-test branch October 1, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants