Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue 78 : DropdownItem Click Event Parameter Type Issue #79

Merged

Conversation

codersyntax
Copy link
Contributor

@codersyntax codersyntax commented Aug 21, 2024

Change dropdown item to return the component instead of just the label to better match the ix core library functionality

💡 What is the current behavior?

Currently, the Dropdown Item component OnClickEvent returns the label string property and does not match the current IX Core functionality

GitHub Issue Number: #78

🆕 What is the new behavior?

With the changes, the Dropdown Item component OnClickEvent returns the DropdownItem component itself allowing access to more properties and matches the functionality of the IX Core.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated
  • 🧪 Unit tests were added/updated and pass (dotnet test)
  • 🏗️ Successful compilation (dotnet build, changes pushed)

👨‍💻 Help & support

change dropdown item to return the component instead of just the label to better match the ix core library functionality
@codersyntax codersyntax changed the title change dropdown item to return the component Resolve Issue 78 : DropdownItem Click Event Parameter Type Issue Aug 21, 2024
@emncnozge emncnozge merged commit b638b2b into siemens:master Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants