Add pattern and selector to PromisePoolCluster#getConnection #3017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
PromisePoolCluster#getConnection
does not match the capabilities ofPoolCluster#getConnection
nor the definition inpromise.d.ts
.This change corrects this by adding the missing
pattern
andselector
parameters which are passed through to the underlying method.Fixes #1381
Note: I may have missed them, but I didn't see any tests for PromisePoolCluster to update or add to with this change.