fix: PoolConnection redundancy when extending Connection interface in TypeScript #1940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #1722 issue:
Once the
PoolConnection.d.ts
has already declared extending theConnection
interface:Then it doesn't needs to re extend the
Connection
inindex.d.ts
#86
like:So, I just removed the
Connection
from extends inindex.d.ts
#86
and it will work:As you recommended in #1722:
For this
PR
, I cloned themaster
and tested it again in a real use (locally), it works perfectly.Extra tests:
Also, without
skipLibCheck
.