fix: typeCast string() parameters for JSON

[jyoonPro]

#1661

[sidorares]

would you be able to add a simple unit test, ideally in the context of json parsing ( e.i: create temp table with json column, insert data, read it using typeCast ) The test need to fail without proposed change to lib/parsers/text_parser.js

The change itself looks good to me. ( I wonder if we should be more helpful proactively? A warning in typeCast if the string() is used without charset AND field type is JSON )

Also could you try to follow https://www.conventionalcommits.org/en/v1.0.0/ in commit messages @jyoonPro?

[jyoonPro]

@sidorares wilco. I'll try it tomorrow.

[jyoonPro]

@sidorares How should we warn the user? I'm not sure if I should use console.log() since no other part of the code seems to be using it.

[sidorares]

@sidorares How should we warn the user? I'm not sure if I should use console.log() since no other part of the code seems to be using it.

This is how we warn when the user awaits non-promise query ( also this is immediately followed by throw so maybe not the best example )

node-mysql2/lib/commands/query.js

Line 42 in 241cb10

console.log(err);

[Marsup]

Shouldn't you also check that encoding is not already utf8? I have a case where field.encoding is, and passing utf8 explicitly still raises the warning.

[Marsup]

My current workaround for whoever is interested is to pass utf-8 instead of utf8 to get rid of the message.