chore: run tests in the buildkit itself #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to remove |
| @@ -1,7 +1,7 @@ | |||
| TOOLS ?= autonomy/tools:b4e3778 | |||
|
|
|||
| # TODO(andrewrynhard): Move this logic to a shell script. | |||
| BUILDKIT_VERSION ?= v0.5.0 | |||
| BUILDKIT_VERSION ?= master@sha256:455f06ede03149051ce2734d9639c28aed1b6e8b8a0c607cb813e29b469a07d6 | |||
There was a problem hiding this comment.
I can update our current deployment to match this.
There was a problem hiding this comment.
Updated and it looks like this works!
There was a problem hiding this comment.
oh, that's awesome!
let me rebase and squash it. still waiting on dockerfile PR, and we can update Dockerfile slug back to upstream
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 34.85% 34.92% +0.07%
==========================================
Files 93 93
Lines 5469 5469
==========================================
+ Hits 1906 1910 +4
+ Misses 3386 3383 -3
+ Partials 177 176 -1
Continue to review full report at Codecov.
|
This relies on two PRs to the buildkit: * moby/buildkit#1081 * moby/buildkit#1085 Sysfs fix was merged to upstream, so updated tag, while using `Dockerfile` slug I can switch to dockerfile2llb with support for `--security=insecure`. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on two PRs to the buildkit, which aren't merged yet, so I
had to do some overrides to apply them:
Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com