Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talosctl dashboard should follow server logs through a reboot #8388

Closed
Tracked by #8549
mrwulf opened this issue Mar 4, 2024 · 0 comments · Fixed by #8570
Closed
Tracked by #8549

Talosctl dashboard should follow server logs through a reboot #8388

mrwulf opened this issue Mar 4, 2024 · 0 comments · Fixed by #8570
Assignees
@utkuozdemir

Comments

@mrwulf
Copy link

mrwulf commented Mar 4, 2024

Feature Request

When rebooting a server (or upgrading, etc) I want to be able to follow the logs with the dashboard. Currently logs end with

user: warning: [2024-03-04T21:36:00.27090814Z]: [talos] service[dashboard](Stopping): Sending SIGTERM to Process(["/sbin/dashboard"])

It would be great if the dashboard kept polling (maybe with a message in the log window) until the server came back up. The top of the dashboard screen does keep polling and successfully reconnects to show node status after reboot.

Description
@smira smira mentioned this issue Mar 5, 2024
Closed
@smira smira mentioned this issue Apr 5, 2024
Closed
@utkuozdemir utkuozdemir mentioned this issue Apr 10, 2024
Merged
smira pushed a commit to smira/talos that referenced this issue Apr 12, 2024
@utkuozdemir @smira
fix: reconnect to the logs stream in dashboard after reboot
028a5b4 
The log stream displayed in the dashboard was stopping to work when a node was rebooted.
Rework the log data source to establish a per-node connection and use a retry loop to always reconnect until the dashboard is terminated.

Print the connection errors in the log stream in red color.

Closes siderolabs#8388.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
(cherry picked from commit 3735add)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@utkuozdemir utkuozdemir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reconnect to the logs stream in dashboard after reboot utkuozdemir/talos
2 participants
@utkuozdemir @mrwulf