Allowing conform to be used in commit-msg git hooks #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrynhard
approved these changes
Oct 8, 2018
| @@ -37,12 +38,21 @@ const TypeFix = "fix" | |||
| // Compliance implements the policy.Policy.Compliance function. | |||
| func (c *Conventional) Compliance(metadata *metadata.Metadata, options ...policy.Option) (report policy.Report) { | |||
| report = policy.Report{} | |||
| if !metadata.Git.IsClean { | |||
| return | |||
| // if !metadata.Git.IsClean { | |||
There was a problem hiding this comment.
nit: can we remove the commented code?
There was a problem hiding this comment.
oh snap I forgot I did that for testing
particledecay
force-pushed
the
commitmsg_file
branch
from
735d757 to
91dedb9
Compare
This allows someone to use `conform enforce` for commit-msg git hooks. fix: removing commented code fix: adding a check for ioutil reading the commit msg file
particledecay
force-pushed
the
commitmsg_file
branch
from
91dedb9 to
81dd051
Compare
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 65.9% 60.78% -5.13%
==========================================
Files 1 1
Lines 44 51 +7
==========================================
+ Hits 29 31 +2
- Misses 11 15 +4
- Partials 4 5 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: adding command line flag for commit msg
This allows someone to use
conform enforcefor commit-msg git hooks.