New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how we can check if JIra Ticket is added with commit or not #180

Closed

NehaSachan opened this issue Oct 8, 2020 · 2 comments · Fixed by #183

NehaSachan commented Oct 8, 2020

So i need a config setting which let me hold if with all correct commit message, do i also added the Jira TIcketID.

As i need to enforce that too in place.

Sample:
"feat: JIRA:XXXX Added authentication code
With creation of OAuth"

Member

andrewrynhard commented Oct 8, 2020

@NehaSachan we only support regex in the scope, but it could be expanded to the description. I can't promise we can get to that soon, but PRs are welcome!

flyhard pushed a commit to flyhard/conform that referenced this issue


          feat: Added support for requiring a Jira issue in the header.

d499ba3

This is meant to fix siderolabs#180

flyhard mentioned this issue

feat: Added support for requiring a Jira issue in the header. #183

Merged

Contributor

flyhard commented Nov 12, 2020

I created a PR. Slight modification to the request since Jira tags are normally are like this: [PROJ-1234]

flyhard pushed a commit to flyhard/conform that referenced this issue


          feat: add support for requiring a Jira issue in the header

621e760

This is meant to fix siderolabs#180
Signed-off-by: Per Abich <per@abich.com>

talos-bot closed this as completed in #183

talos-bot pushed a commit that referenced this issue


          feat: add support for requiring a Jira issue in the header

001de56

This is meant to fix #180
Signed-off-by: Per Abich <per@abich.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment