Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added countdown finished callback #64

Merged
merged 2 commits into from
Jun 28, 2014
Merged

Added countdown finished callback #64

merged 2 commits into from
Jun 28, 2014

Conversation

itslenny
Copy link
Contributor

Added a callback for when the countdown is finished that can be referenced in html using an attribute. This allows you to have a function in your controller's scope fired when the countdown finishes which enables your app to easily take an action when the countdown naturally finishes.

For example, if you had a count down to the start of an online event you could trigger the action that would hide the timer and take the user in to the event once the countdown is finished.

…riggers when countdown finishes on it's own (not when it is stopped by a user). Useful if your app should take somea action when the countdown is reached.
@siddii
Copy link
Owner

siddii commented Apr 17, 2014

@itslenny - Can you please pull stuff from master so I can review this PR?

@rajexcited
Copy link
Contributor

Hi,

Can you please change it to provide callback function on given specific Time. Like start, stop method. Could you please make notify function for specific time which triggers an event or callback function in our application and application can handle it. Let me know if you make this change. So i don't have to.

Thanks,

@davorpeic
Copy link

Is this feature (callback function for end) merged with master?
thanks

@siddii
Copy link
Owner

siddii commented Jun 11, 2014

No, its not merged into master yet. I'll see if I can merge it as soon as possible.

@mmly
Copy link

mmly commented Jun 23, 2014

Adding this callback is really nice feature, when do you roughly estimate to marge it ?

@siddii
Copy link
Owner

siddii commented Jun 24, 2014

@mmly I am working on it in the local branch. It will be available before the week ends.

@itslenny
Copy link
Contributor Author

@siddii Sorry I couldn't get this ready for merge. I got really busy after I initially submitted it.

@siddii
Copy link
Owner

siddii commented Jun 24, 2014

@itslenny - No problem. I'll pull this into my local branch & cleanup little bit before merging it to the master.

@siddii siddii merged commit 712f1fa into siddii:master Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants