Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newlines and correct license year #1579

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Remove newlines and correct license year #1579

merged 3 commits into from
Dec 4, 2019

Conversation

sybernix
Copy link
Contributor

@sybernix sybernix commented Dec 4, 2019

$Subject

@sybernix sybernix mentioned this pull request Dec 4, 2019
Merged
suhothayan
suhothayan reviewed Dec 4, 2019
View reviewed changes
modules/siddhi-core/src/main/java/io/siddhi/core/table/CacheTableLRU.java Outdated
@@ -77,15 +78,15 @@ public void deleteEntriesUsingCachePolicy(int numRowsToDelete) {
indexEventHolder.deleteAll();
} else {
Set<Object> keys = indexEventHolder.getAllPrimaryKeyValues();
TreeMap<Long, Object> toDelete = new TreeMap<>();
Map<Long, Object> toDelete = new TreeMap<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't this in this case (within a function we need to use Map) because this use case specifically needs TreeMap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted back in 0c7f80d

@sybernix sybernix changed the title Improve cache code quality Remove newlines and correct license year Dec 4, 2019
@codecov-io
Copy link

codecov-io commented Dec 4, 2019 •
edited
Loading

Codecov Report

Merging #1579 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1579   +/-   ##
========================================
  Coverage      67.7%   67.7%           
  Complexity       45      45           
========================================
  Files           650     650           
  Lines         27471   27471           
  Branches       4330    4330           
========================================
  Hits          18598   18598           
+ Misses         7062    7060    -2     
- Partials       1811    1813    +2
Impacted Files Coverage Δ Complexity Δ
.../operator/OverwriteTableIndexOperatorForCache.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...hi/core/table/holder/IndexEventHolderForCache.java 18.75% <ø> (ø) 0 <0> (ø) ⬇️
...ut/stream/state/AbsentStreamPreStateProcessor.java 82.11% <0%> (-1.33%) 0% <0%> (ø)
...o/siddhi/core/aggregation/IncrementalExecutor.java 80.46% <0%> (-0.79%) 0% <0%> (ø)
...e/src/main/java/io/siddhi/core/util/Scheduler.java 83.54% <0%> (+1.89%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604d55f...eacf127. Read the comment docs.

@suhothayan suhothayan merged commit 1ab8dde into siddhi-io:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhothayan suhothayan suhothayan approved these changes

@ramindu90 ramindu90 ramindu90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sybernix @codecov-io @suhothayan @ramindu90