Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature update/ref script size #98

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Conversation

twwu123
Copy link
Collaborator

@twwu123 twwu123 commented Oct 20, 2024

Summary

Reference inputs can have scripts, current APIs do not allow the input of script size, which hinders fee calculations for such inputs.

BREAKING: All read_only_reference_input must include a script size argument of Option<usize>, an argument of None implies there is no script attached to this UTxO.

Type of Change

Please mark the relevant option(s) for your pull request:

Feature Change

Type of feature change:

  1. New feature - non-breaking change which adds functionality
  2. Breaking change - fix or feature that would cause existing functionality to not work as expected
  • Rust crate whisky - New feature
  • Rust crate whisky - Breaking change
  • WASM sidan-csl-rs - New feature
  • WASM sidan-csl-rs - Breaking change

Checklist

  • My code is appropriately commented and includes relevant documentation, if necessary
  • I have added tests to cover my changes, if necessary
  • I have updated the documentation, if necessary
  • All new and existing tests pass
  • Both rust and wasm build pass

Additional Information

Current design for sidan-csl-rs side is a little bit hacky when adding reference scripts for other actions that isn't read_only_reference_input. Since script_size is already considered in the script_source, it is input as None in the ref_input even though this is technically not true.

Copy link
Contributor

@HinsonSIDAN HinsonSIDAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HinsonSIDAN HinsonSIDAN merged commit 455844e into master Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants