Get ElasticSearch automatic role generation working #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional 'domain' config item (rather than overloading the 'endpoint' config item).
According to https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-ac.html (and according to my testing) these actions need to be applied to a subresource of the ES domain, not to the domain itself.
|
Thank you @mfogel for your contrib. LGTM |
bboure
reviewed
Apr 18, 2020
src/index.js
Outdated
| if (typeof ds.config.endpoint === 'string') { | ||
| if (ds.config.domain) { | ||
| arn = { 'Fn::Join': ['/', [{ 'Fn::GetAtt': [ds.config.domain, 'Arn'] }, '*']] }; | ||
| } else if (ds.config.endpoint) { |
There was a problem hiding this comment.
@mfogel Can we keep the check typeof ds.config.endpoint === 'string' ?
This will avoid the code below to break on other values.
If something else than a string comes here, let the Error to be thrown on line 715.
There was a problem hiding this comment.
@mfogel I have applied this change for you.
Will merge soon
Thank you again
|
Released in 1.3.0 🎉 |
|
wonderful, thank you @bboure ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets automatic role generation working, when using elastic search service as a data source, as discussed on #233
Rather than overload the
endpointconfig key, this PR adds an optionaldomainconfig key which is to be a reference to a resource of typeAWS::Elasticsearch::Domain.If
domainis provided,endpointno longer needs to be provided - it is automatically derived from thedomainreference.This also adds
es:ESHttpPatchto the list of actions enabled by automatic role generation, since it's one of the 6 basic ones listed in the AWS docs on ElasticSearch IAM roles.I wouldn't view this as a backward-incompatible change because the previous version of this (with the overloaded
endpointkey), AFAIK, didn't work.I'm now using this on a live personal deployment of mine with the following config:
Short and sweet.
Let me know if there's any changes or tweaks you'd like to see, thanks & cheers