Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssl support for redis with sentinel #258

Merged
merged 2 commits into from
Nov 23, 2023
Merged

add ssl support for redis with sentinel #258

merged 2 commits into from
Nov 23, 2023

Conversation

cyberjunk
Copy link
Contributor

@cyberjunk cyberjunk commented Sep 23, 2023

redbeat can already connect to sentinel using tls by setting sentinel_kwargs in redbeat_redis_options accordingly, e.g.:

'sentinel_kwargs': { 'ssl': True, 'ssl_cert_reqs': ssl.CERT_NONE }

this will be passed to the Sentinel() constructor and works fine for the connection from redbeat to sentinel.

however, this is only one of the two connections made from redbeat in a redis+sentinel setup...
the next connection which is made to the returned redis master afterwards was always without tls.

to make the connection to redis also use tls, one has to pass the according ssl related connection_kwargs to Sentinel() constructor.

I adapted the code from the encrypted rediss case below:
checking if redis_use_ssl is defined, and if so, set ssl to True and inject the parameters provided in redis_use_ssl for the connection from redbeat to redis. this way redbeat can be configured to use tls on both, the sentinel AND the redis connection using existing configuration settings and it's working fine for me now...

@sibson sibson closed this Nov 23, 2023
@sibson sibson reopened this Nov 23, 2023
@sibson sibson merged commit a1ab79d into sibson:main Nov 23, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants