Skip to content

Commit

Permalink
Turn on --experimental_starlark_config_transitions
Browse files Browse the repository at this point in the history
RELNOTES: Turn on --experimental_starlark_config_transitions by default for starlark transitions (see https://docs.bazel.build/versions/master/skylark/config.html#user-defined-transitions for more info)

SKIP_CI=blaze is borked
PiperOrigin-RevId: 250776283
  • Loading branch information
juliexxia authored and copybara-github committed May 30, 2019
1 parent aa0cb61 commit a626990
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,9 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl
+ "debugging.")
public boolean experimentalPlatformsApi;

// TODO(cparsons): Resolve and finalize the transition() API. The transition implementation
// function should accept two mandatory parameters, 'settings' and 'attr'.
@Option(
name = "experimental_starlark_config_transitions",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.EXPERIMENTAL},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ public static Builder builderWithDefaults() {
.experimentalGoogleLegacyApi(false)
.experimentalJavaCommonCreateProviderEnabledPackages(ImmutableList.of())
.experimentalPlatformsApi(false)
.experimentalStarlarkConfigTransitions(false)
.experimentalStarlarkConfigTransitions(true)
.experimentalStarlarkUnusedInputsList(false)
.incompatibleBzlDisallowLoadAfterStatement(true)
.incompatibleDepsetIsNotIterable(false)
Expand Down

0 comments on commit a626990

Please sign in to comment.