-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: postgres arrays #233
Conversation
8fd7bee
to
dcb9511
Compare
LGTM in general. One question, why did you change the return type of: fn try_match_value(row: &PgRow, column: &PgColumn) -> Result<serde_json::Value> from |
@christoshadjiaslanis for json import support. The json object can be read by sqlx here inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor thing but otherwise looks good to me too :)
4bdbc90
to
1800fea
Compare
Suggestion addressed, thanks @WiredSound 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me :)
d276b14
to
5482054
Compare
Allows generating and importing postgres arrays to close #171. Also covers array of json generation and json importing to close #67.
Things that don't work
Value::String
which cause them to betext
here. Adding aValue::Uuid
type should fix this, I will just need guidance about how please 😄one_of
null does work.json[]
) does not work. Instead just using the simple postgresjson
type with an array in it ({[]}
) does work - schema and generation definition