Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ⌨️ fix typo #1855

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: ⌨️ fix typo #1855

merged 1 commit into from
Aug 7, 2024

Conversation

rodneylab
Copy link
Contributor

Description of change

Fixes typo in cargo deploy successful deployment message (in Terminal). Closes #1854

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oddgrd oddgrd merged commit b8aa727 into shuttle-hq:main Aug 7, 2024
25 checks passed
@rodneylab rodneylab deleted the fix__typo branch August 7, 2024 06:43
@jonaro00
Copy link
Member

jonaro00 commented Aug 8, 2024

@oddgrd Sadly a comment for this was never added in the code: #1360 (comment)
The least annoying/breaking solution has been to keep the typo. (Won't be there on beta platform)

@oddgrd
Copy link
Contributor

oddgrd commented Aug 8, 2024

@jonaro00 Oh! I'll revert it and add a comment tomorrow, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Typo in runtime successful deployment message
3 participants