Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): change project owner #1725

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Apr 5, 2024

Description of change

Admin command to change project owner.
Some improvements to admin internals and permit client errors.

How has this been tested? (if applicable)

  • On local stack with permit dev env

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

admin/src/client.rs Show resolved Hide resolved
backends/src/client/permit.rs Outdated Show resolved Hide resolved
gateway/src/service.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit 😅

@@ -13,7 +13,7 @@ use wiremock::{
};

use crate::client::{
permit::{Error, Organization},
permit::{Organization, Result},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having Result come from permit is weird

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skill issue :D

@jonaro00 jonaro00 merged commit d26e6c8 into shuttle-hq:main Apr 5, 2024
20 of 24 checks passed
@jonaro00 jonaro00 deleted the admin-create-user-move-project branch April 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants