Add --allow-dirty to command hint at end of init #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the command hint `cargo shuttle deploy` that appears at the end of `cargo shuttle init` so that it includes the `--allow-dirty` flag. Without this flag, `cargo shuttle` will fail every time a newbie tries to init a new project because shuttle adds files to the project but doesn't commit them to git. Shuttle then notices that there are uncommitted files, and doesn't allow the newbie to deploy the project without specifically allowing the dirty files. This is a bit of a bad experience, because the newbie is just following instructions but also being told that those instructions were wrong.
iulianbarbu
approved these changes
Jul 10, 2023
|
Thanks! |
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
This commit modifies the command hint `cargo shuttle deploy` that appears at the end of `cargo shuttle init` so that it includes the `--allow-dirty` flag. Without this flag, `cargo shuttle` will fail every time a newbie tries to init a new project because shuttle adds files to the project but doesn't commit them to git. Shuttle then notices that there are uncommitted files, and doesn't allow the newbie to deploy the project without specifically allowing the dirty files. This is a bit of a bad experience, because the newbie is just following instructions but also being told that those instructions were wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the command hint
cargo shuttle deploythat appears at the end ofcargo shuttle initso that it includes the--allow-dirtyflag.Without this flag,
cargo shuttlewill fail every time a newbie tries to init a new project because shuttle adds files to the project but doesn't commit them to git. Shuttle then notices that there are uncommitted files, and doesn't allow the newbie to deploy the project without specifically allowing the dirty files. This is a bit of a bad experience, because the newbie is just following instructions but also being told that those instructions were wrong.This PR is a bit of a nit-pick, so feel free to close!