Use XDG config folder instead of .shutter stray folder #492
Conversation
Changed the sometimes hardcoded settings path to instead use `.config/shutter` instead of `.shutter`. Respects standards and the home folder.
|
Looks like our tests expect the ~/.shutter dir. |
|
(I can have a look at the tests, it's just that I know nothing about Perl and could not run from source) |
|
Unfortunately, I know nothing about Perl as well, so I guess, we need input from the more knowledgeable guys. 😃 |
Changed tests to reflect config folder change.
|
@artscoop let me checkout into your master branch and pass tests. I'll try to do it today or tomorrow |
|
Hi, thank you very much! I've added you as a collaborator to the project. |
|
ok, it will take a while. Give me a couple of days |
| @@ -260,6 +260,7 @@ my $so = Shutter::App::Options->new($sc, $shf); | |||
| #set home | |||
| #-------------------------------------- | |||
| $ENV{'HOME'} = Shutter::App::Directories::get_home_dir(); | |||
| $ENV{'CONFIG'} = Shutter::App::Directories::get_config_dir(); | |||
There was a problem hiding this comment.
Why does this need to be in the process environment?
There was a problem hiding this comment.
it's not needed. I'll drop it.
|
This closes #67 |
| @@ -66,7 +65,7 @@ sub get_home_dir {Glib::get_home_dir} | |||
| sub get_config_dir {Glib::get_user_config_dir} | |||
|
|
|||
| sub create_hidden_home_dir_if_not_exist { | |||
There was a problem hiding this comment.
This function name doesn't reflect anymore what this function does, as the shutter dir is not longer "hidden", and not necessary in home
I think we should move the current data from |
|
Hello, any progress to be made? |
Changed the sometimes hardcoded settings path to instead use
.config/shutterinstead of.shutter. Respects XDG standards and the home folder.Needs testing since I know nothing about Perl and could not execute project.