Fix capitalization of alert name in GitHub alert HOC (#4083)

* fix capitalization of alert name in GitHub alert HOC * improve github alert syntax name in DOM --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
shuding · Jan 28, 2025 · 19578c3 · 19578c3
1 parent 29a44de
commit 19578c3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.changeset/nice-weeks-dream.md b/.changeset/nice-weeks-dream.md
@@ -0,0 +1,5 @@
+---
+"nextra": patch
+---
+
+improve github alert syntax name in DOM
diff --git a/packages/nextra/src/client/hocs/with-github-alert.tsx b/packages/nextra/src/client/hocs/with-github-alert.tsx
@@ -36,14 +36,13 @@ export function withGitHubAlert(
               `Invalid GitHub alert type: "${alertName}". Should be one of: ${GITHUB_ALERTS.join(', ')}.`
             )
           }
+          const capitalizedName =
+            alertName[0]!.toUpperCase() + alertName.slice(1)
           return fn({
             ...props,
             type: alertName as T,
             children: [
-              <b key={0}>
-                {alertName[0]!.toUpperCase()}
-                {alertName.slice(1)}
-              </b>,
+              <b key={0}>{capitalizedName}</b>,
               ...props.children.slice(2)
             ]
           })