Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the chain representation? #90

Closed
liwt31 opened this issue May 16, 2020 · 2 comments
Closed

Remove the chain representation? #90

liwt31 opened this issue May 16, 2020 · 2 comments

Comments

@liwt31
Copy link
Collaborator

liwt31 commented May 16, 2020

When constructing MPO based on MolList it is possible to choose star representation or chain representation. As far as I know, the chain representation is seldomly used and not well tested. Besides, the task of choosing representation would be advanced to writing the model if MolList2 is used and the inconsistency constitutes a barrier to combine MolList and MolList2.
It'll probably be a good idea to remove the chain representation, which IMO is a legacy of the old ephMPS.
@jjren
Copy link
Collaborator

jjren commented May 18, 2020

I agree. Chain representation could be easily used with MolList2 now. So, it could be removed.

@liwt31
Copy link
Collaborator Author

liwt31 commented May 18, 2020

I'll see if I can get this done when merging MolList and MolList2.

This was referenced Jul 10, 2020
Closed
Merged
@liwt31 liwt31 closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjren @liwt31