-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Mollist2 as internal system information data structure #100
Comments
Update the interface of MolList2Unification of the interfacesThe class
All of the class methods will transform the input information into the arguments that In my opinion, all of the three class methods should be deprecated since it is almost always more efficient and precise to construct the model with The new interface for the
|
|
I agree with the other improvements. |
I don't quite understand. The calculation (pattern for tensor contraction) is essentially the same for either scheme < 4 or scheme = 4.
This update will not affect me much. I'm using time dependent Hamiltonian.
Good point. Never mind. Using † is a crazy geek idea. I'll make it possible for external users to use † though, and internally it is converted to |
I mean the time cost when constructing a lot of simple MPOs mentioned in your first post. |
This is an extension to the discussion in #82 , in which I proposed to use
MolList2
as the internal data structure to keep track of system information and remove the original MPO construction function. At that time, major concerns arise on the performance in large systems. During my usage of the module for about 3 months, I found no performance problem, because MPO construction is always so small a portion of the total time cost. After all, the original code is designed for Holstein Hamiltonian which is almost the simplest Hamiltonian we can think of. When constructing these simple Hamiltonian, the general MPO construction routine is generally efficient. One thing that worries me is that I feel (no benchmark, just feeling) the algorithm is a little bit slow when constructing a lot of simple MPOs such as in the case ofcalc_reduced_density_matrix
, this can certainly be improved but has a lower priority.Of course, any discussions on this issue are still welcome.
This would a very big update. Contents include:
MolList2
as internal system information data structureMollist2
backend, a moderate endeavor of coding is required, which may not be justified if the feature is going to be removed.MolList2
as discussed in Enhance green-kubo transport and refactor transport module #97 . The details will be updated in a comment to this issue.The text was updated successfully, but these errors were encountered: