Upgrade to rust 2021 and drop itertools #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I took a look at sqlformat-rs after seeing your comment in the sqlx issue and noticed that starting from Rust 1.56 it will be possible to drop the dependency on itertools, since
.join("something")
can easily be implemented with.intersperse("something").collect()
thanks to the newly stabilized Intersperse api.Feel free to leave this PR sitting until it makes sense to bump the MSRV to 1.56