Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rust 2021 and drop itertools #11

Closed
wants to merge 3 commits into from
Closed

Upgrade to rust 2021 and drop itertools #11

wants to merge 3 commits into from

Conversation

paolobarbolini
Copy link

@paolobarbolini paolobarbolini commented Sep 12, 2021

Hello, I took a look at sqlformat-rs after seeing your comment in the sqlx issue and noticed that starting from Rust 1.56 it will be possible to drop the dependency on itertools, since .join("something") can easily be implemented with .intersperse("something").collect() thanks to the newly stabilized Intersperse api.

Feel free to leave this PR sitting until it makes sense to bump the MSRV to 1.56

@shssoichiro
Copy link
Owner

Neat! I think this looks good, I'll wait to merge until 1.56 stable is published. Thanks!

@paolobarbolini
Copy link
Author

The intersperse stabilization has been reverted because of incompatibility with itertools rust-lang/rust#89638. This will have to wait a few more versions

@shssoichiro
Copy link
Owner

Replaced by #34

@shssoichiro shssoichiro closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants