-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of release binary #592
Conversation
@andrews05 - thanks for implementing this! Is the new image for testing permissively licensed?
Many thanks :-) |
The image is just a copy of another one in the test suite (see #129 - it comes from a corpus of png test images).
|
Totally understand your points but it's a shame to not adopt (3), which seemed to save ~30% binary size. |
Yeah, I agree. It's a shame that rust can't avoid the bloat more easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes look good, thanks!
Given that we're already using a nightly toolchain for the release builds, I don't think going with build-std
is that difficult, but it surely comes with the tradeoff of slower CI times. We can explore that option in more depth in the future; the changes in this PR are not mutually exclusive with that.
This PR makes 3 changes that together reduce binary size by around 25%:
Closes #571
An unrelated change: I've replaced the zopfli test file with a smaller one that runs much faster, as well as removing the slow test for issue-133 which was related to an older alpha optimisation that is no longer relevant.