Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHRINKRES-345] Remove automatic activation of dependency version bum… #239

Conversation

xjusko
Copy link
Contributor

@xjusko xjusko commented Jul 25, 2024

@xjusko xjusko requested a review from petrberan July 25, 2024 18:53
@petrberan
Copy link
Member

@xjusko The JIRA states that the script should be run via profile. Which profile is used to run the script?

@xjusko
Copy link
Contributor Author

xjusko commented Jul 29, 2024

@xjusko The JIRA states that the script should be run via profile. Which profile is used to run the script?

@petrberan You can run the script when building the project with -Pdependency-version-bump-unix flag, so for example:
mvn clean install -Pdependency-version-bump-unix
Or did I misunderstand what you meant by "run via profile"?

@xjusko xjusko force-pushed the remove-automatic-activation-of-version-bump-script branch from 436de43 to 55bf16a Compare August 5, 2024 09:56
Copy link
Member

@petrberan petrberan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @xjusko

@petrberan petrberan merged commit cb55dce into shrinkwrap:master Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants