Skip to content

Commit

Permalink
CLOCK IS UNSTUCK! But also needs testing and probably a proper fix
Browse files Browse the repository at this point in the history
[    3.648013] ------------[ cut here ]------------
[    3.655981] WARNING: CPU: 3 PID: 161 at drivers/clk/qcom/clk-branch.c:91 clk_branch_toggle+0x180/0x18c
[    3.665341] mmss_s0_axi_clk status stuck at 'off'
[    3.665344] Modules linked in: qnoc_msm8974(+) icc_smd_rpm pm8941_pwrkey
[    3.665366] CPU: 3 PID: 161 Comm: modprobe Tainted: G        W         5.6.0-rc6 #4-postmarketos-qcom-msm8974
[    3.665372] Hardware name: Generic DT based system
[    3.678462] [<c0312f68>] (unwind_backtrace) from [<c030d85c>] (show_stack+0x10/0x14)
[    3.690096] [<c030d85c>] (show_stack) from [<c0c60020>] (dump_stack+0x84/0x98)
[    3.704585] [<c0c60020>] (dump_stack) from [<c03225c4>] (__warn+0xd0/0xf8)
[    3.704603] [<c03225c4>] (__warn) from [<c03229a0>] (warn_slowpath_fmt+0x98/0xc4)
[    3.715610] [<c03229a0>] (warn_slowpath_fmt) from [<c07612c8>] (clk_branch_toggle+0x180/0x18c)
[    3.715630] [<c07612c8>] (clk_branch_toggle) from [<c0751d40>] (clk_core_enable+0x7c/0x304)
[    3.715643] [<c0751d40>] (clk_core_enable) from [<c0751fe0>] (clk_core_enable_lock+0x18/0x2c)
[    3.727584] [<c0751fe0>] (clk_core_enable_lock) from [<c074fd58>] (clk_bulk_enable+0x20/0x70)
[    3.727612] [<c074fd58>] (clk_bulk_enable) from [<bf01012c>] (msm8974_icc_probe+0xf0/0x2b8 [qnoc_msm8974])
[    3.727640] [<bf01012c>] (msm8974_icc_probe [qnoc_msm8974]) from [<c086dfd4>] (platform_drv_probe+0x48/0x98)
[    3.737573] [<c086dfd4>] (platform_drv_probe) from [<c086ba54>] (really_probe+0x24c/0x484)
[    3.737586] [<c086ba54>] (really_probe) from [<c086be58>] (driver_probe_device+0x78/0x1c8)
[    3.737597] [<c086be58>] (driver_probe_device) from [<c086c208>] (device_driver_attach+0x58/0x60)
[    3.737609] [<c086c208>] (device_driver_attach) from [<c086c2c4>] (__driver_attach+0xb4/0x154)
[    3.750159] [<c086c2c4>] (__driver_attach) from [<c0869a40>] (bus_for_each_dev+0x78/0xc0)
[    3.766825] [<c0869a40>] (bus_for_each_dev) from [<c086aba8>] (bus_add_driver+0x170/0x20c)
[    3.766836] [<c086aba8>] (bus_add_driver) from [<c086cea0>] (driver_register+0x7c/0x114)
[    3.766852] [<c086cea0>] (driver_register) from [<c0302fb4>] (do_one_initcall+0x58/0x2b0)
[    3.779156] [<c0302fb4>] (do_one_initcall) from [<c03aee7c>] (do_init_module+0x60/0x248)
[    3.797384] [<c03aee7c>] (do_init_module) from [<c03b13d4>] (load_module+0x22ec/0x2780)
[    3.797395] [<c03b13d4>] (load_module) from [<c03b1b14>] (sys_finit_module+0xe8/0x120)
[    3.797408] [<c03b1b14>] (sys_finit_module) from [<c0301000>] (ret_fast_syscall+0x0/0x54)
[    3.812306] Exception stack(0xed11ffa8 to 0xed11fff0)
[    3.812330] ffa0:                   9b5e880c b6f46550 00000003 00564b94 00000000 b6f48570
[    3.828641] ffc0: 9b5e880c b6f46550 0000017b 0000017b b6f48570 00000001 00000000 005786a0
[    3.828657] ffe0: b6f48570 be914be0 004e0205 b6ef90ba
[    3.837947] l17: supplied by vreg-boost
[    3.846065] ---[ end trace c7b2c6d72ddc2c20 ]---

--

Same solution, different commit:
SoMainline@0946916

TODO! Proper solution is CLK_IS_CRITICAL on mmss_s0_axi instead of this,
like on 8994 (apparently)
  • Loading branch information
konradybcio authored and z3ntu committed May 20, 2024
1 parent 1473883 commit cb59aaf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/clk/qcom/mmcc-msm8974.c
Original file line number Diff line number Diff line change
Expand Up @@ -2163,11 +2163,11 @@ static struct clk_branch mmss_s0_axi_clk = {
.hw.init = &(struct clk_init_data){
.name = "mmss_s0_axi_clk",
.parent_hws = (const struct clk_hw*[]){
&mmss_axi_clk_src.clkr.hw
&mmss_mmssnoc_axi_clk.clkr.hw
},
.num_parents = 1,
.ops = &clk_branch2_ops,
.flags = CLK_IGNORE_UNUSED,
.flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_OPS_PARENT_ENABLE,
},
},
};
Expand Down

0 comments on commit cb59aaf

Please sign in to comment.