Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant ingredients could not be selected #263

Conversation

DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Sep 4, 2024

Fixes #260, and adds some tests that will help prevent it from happening again. No changelog entry because this was introduced after 0.8.1.

Besides the unit tests, I also confirmed the UI correctly handled fluid variant selection for both fuel and ingredients, and that the links behaved correctly in the supplied project page.

@DaleStan DaleStan requested a review from Dorus September 4, 2024 17:52
Copy link
Collaborator

@Dorus Dorus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this solves the issue in #260.

Probably your test coves this, but i find it hard to fully understand them easily so here are the scenario's that would need testing:

Swapping out a fluid ingredient for a hotter one, the new recipe should now be in that row.
Link the hotter recipe (with rightclick), the hotter recipe should now have a link. The current row should have that link.

Production and consumption of each temperature of the ingredient should individually add up on extra products or ingredients throughout these tests.

@shpaass
Copy link
Owner

shpaass commented Sep 4, 2024

Swapping out a fluid ingredient for a hotter one, the new recipe should now be in that row.
Link the hotter recipe (with rightclick), the hotter recipe should now have a link. The current row should have that link.
Production and consumption of each temperature of the ingredient should individually add up on extra products or ingredients throughout these tests.

@Dorus, do these scenarios pass when you playtest them?

@Dorus
Copy link
Collaborator

Dorus commented Sep 5, 2024

Yes, those are the scenarios I've confirmed to be working now.

@shpaass
Copy link
Owner

shpaass commented Sep 5, 2024

Since the playtesting passes, I'm merging it now to not keep the feature hostage.
@DaleStan, you are free to add tests as another PR whenever you want.
@Dorus, you can create an issue about the tests if you want.

@shpaass shpaass merged commit 6722dd9 into shpaass:master Sep 5, 2024
1 check passed
@DaleStan DaleStan deleted the 260-different-temperature-fluidsgas-links-up-wrongly branch September 6, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different temperature fluids/gas links up wrongly
3 participants