fix: Prevent silent solver failures. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpaass
force-pushed
the
fix-solver-failures
branch
from
c330140
to
25dac64
Compare
Crafters with no energy source would halt the solver with silently-ignored exceptions. Turn them into user-visible errors, and let the solver do its best with the information it has.
The main idea of the commit is to change this: if ((recipe.entity.energy?.fuels.Length ?? 0) == 0) into this if (energy == null || energy.fuels.Length == 0) with the assumption that these two lines serve the identical purpose. If this assumption is wrong then this commit is wrong. The reason for this change is the desire to get rid of the "??" and make the understanding of the "if" easier. The rest of the changes are the application of the rename because why not. Also wrap a line, so it does not go beyond 120 character limit.
shpaass
force-pushed
the
fix-solver-failures
branch
from
25dac64
to
f320c78
Compare
shpaass
approved these changes
Sep 4, 2024
veger
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crafters with no energy source would halt the solver with silently-ignored exceptions. Turn them into user-visible errors, and let the solver do its best with the information it has.
I discovered this while playing with Exotic Industries. With this mod-fix and project, the solver will silently refuse to deal with the page. (Remove the "Bio matter: insulated wire" tech, and the solver will come back to life.) With this fix, Yafc will display an error on the "Bio matter: insulated wire" tech, and will solve the page.
(The fix a mod developer should make is to uncomment the commented line in the mod-fix, but silent errors are bad UX, even if the error is someone else's fault.)