Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tabs using Ctrl+PgUp/Down, reorder tabs using Ctrl+Sh+PgUp/Down #236

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

exyi
Copy link

@exyi exyi commented Aug 15, 2024

The keymapping matches web browsers, VS Code and other software with tabs.

This patch also requires that scrolling shortcuts do not accept modifier keys, so ScrollArea.KeyDown is strictened accordingly.

@shpaass
Copy link
Owner

shpaass commented Aug 16, 2024

Hello @exyi!
Could you please separate the refactoring and new functionality into different commits? It would help with potential debugging in the future.
If it's too much work, please let us know.

@shpaass
Copy link
Owner

shpaass commented Aug 16, 2024

I'm not sure how a user would be able to discover these shortcuts.
As one of the options, we could have a file Docs/Shortcuts.md that lists all the shortcuts.
In this PR, you could either list all the shortcuts or put just the ones you added -- it's fine to not add them all at once.

This change is necessary for example to map
Ctrl+PgDown to something different than scrolling one page down.
This keymapping matches web browsers, VS Code and other software with tabs.
Basic shortcuts like keyboard navigation in a textbox, scrolling,
ESC to close modal, ... are not listed
@exyi
Copy link
Author

exyi commented Aug 21, 2024

Hi! Sorry for the delay, I have just separated changes in ScrollArea and then the tab keymapping. I have added the Docs/Shortcuts.md file and also listed the other shortcuts which I could find. If you know of some other, let me know, I can add them too, or we can add them later

@veger
Copy link
Collaborator

veger commented Aug 21, 2024

It would be nice to add a link to the new Shortcuts.md in the main page/README, so users will (hopefully) find it

@shpaass
Copy link
Owner

shpaass commented Aug 21, 2024

It would be nice to add a link to the new Shortcuts.md in the main page/README, so users will (hopefully) find it

I'll handle that after we merge this PR.

@shpaass shpaass merged commit 5f26d81 into shpaass:master Aug 21, 2024
1 check passed
@shpaass
Copy link
Owner

shpaass commented Aug 21, 2024

I'll handle that after we merge this PR.

Added the link to Shortcuts in Readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants