Encode strings as UTF8 when sending them to Lua, to match the string decoding. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleStan
force-pushed
the
200-schallalienloot-has-a-richness-error-when-loaded
branch
from
59f14b0
to
1e2e463
Compare
shpaass
approved these changes
Jul 23, 2024
DaleStan
deleted the
200-schallalienloot-has-a-richness-error-when-loaded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua uses UTF8 strings, not Ansi. This usually doesn't matter, except that Schall Alien Loot has setting values containing the character
×(U+00D7), and this gets garbled when loaded from mod-settings.dat.In addition to Schall, I checked loading with AngelBobMadClown, ExoticIndustries, IR3, Nullius, Pyanodon, and SE. The only error I encountered was #105.