Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change pages with ctrl-tab #199

Merged
merged 5 commits into from
Jul 22, 2024
Merged

feat: change pages with ctrl-tab #199

merged 5 commits into from
Jul 22, 2024

Commits on Jul 21, 2024

  1. feat: change pages with ctrl-tab 

    Use the common browser interaction ctrl-tab to switch pages forward and alt-tab to switch pages back.

Implementation-wise, we have to break a little layering by using the displayPages list of guids that really only the tab bar is supposed to care about... but we have to call ChangePage in the main screen, so I'm not sure how else to do it.

The other change of note is forcing a focus change when you switch tabs; this is to get any active dropdowns (i.e. the GoodsIcon dropdowns for switching recipes or switching modules) to disappear if you hit control-tab while one is open, since the mouse isn't otherwise moving and clicking like it would be if you switched tabs with the mouse.
    @sfoster1
    sfoster1 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    c11aae1 View commit details
    Browse the repository at this point in the history

  2. fixup: Add some documentation 

    - Changelog update
- Clarify just why we're resetting focus there
    @sfoster1
    sfoster1 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    9da23a0 View commit details
    Browse the repository at this point in the history

  3. fixup: remove accidental whitespace

    @sfoster1
    sfoster1 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    cf4014d View commit details
    Browse the repository at this point in the history

  4. fixup: remove default for forward and document

    @sfoster1
    sfoster1 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    919b96d View commit details
    Browse the repository at this point in the history

  5. refactor: move to first page if no page active 

    Also, fix a data consistency issue - the page delete button in the page settings pane wasn't removing the pane from the display pages list, just marking it for deletion. The page still wouldn't be displayed but it would be in the list, which wasn't an issue when we just pick items out of the list based on what's displayed but became an issue when we iterate through it.
    @sfoster1
    sfoster1 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    66869b9 View commit details
    Browse the repository at this point in the history