Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Enter from closing the project page settings dialog when the name is empty. #190

Conversation

DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Jul 1, 2024

Fix #188

@DaleStan DaleStan requested a review from shpaass July 1, 2024 23:53
@shpaass shpaass force-pushed the 188-its-possible-to-make-a-sheet-with-an-empty-name-if-you-use-the-enter-shortcut branch from a3fd352 to 013ac03 Compare July 2, 2024 07:49
@shpaass
Copy link
Owner

shpaass commented Jul 2, 2024

Rebased on the fresh master.

@shpaass shpaass merged commit 20b8f19 into shpaass:master Jul 2, 2024
1 check passed
@DaleStan DaleStan deleted the 188-its-possible-to-make-a-sheet-with-an-empty-name-if-you-use-the-enter-shortcut branch July 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's possible to make a Sheet with an empty name if you use the Enter shortcut
2 participants