Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix horizontal scrollbar #161

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Fix horizontal scrollbar #161

merged 8 commits into from
Jun 19, 2024

Commits on Jun 18, 2024

  1. Document Scroll classes

    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    48e9a8b View commit details
    Browse the repository at this point in the history

  2. Rename scrollX, scrollY and scroll properties 

    Now they actually reflect what they are about
    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6d03467 View commit details
    Browse the repository at this point in the history

  3. Cleanup Scrollable class 

    * Get rid of misleading height property
  (a visible area height is needed instead)
* MeasureContent only uses width, so replace Rect param
* Rename Scrollbar Rects to make their purpose more clear
* Document code blocks to clarify a little better what happens
    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    491712c View commit details
    Browse the repository at this point in the history

  4. Make horizontal scrollbar clickable/dragable 

    rect.Heigth does not need the correction for the ScrollbarSize when not
building. It does not have the correction when it is building. So with
this fix both the building and not building states use the same
rect.Height.
    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d9f8151 View commit details
    Browse the repository at this point in the history

  5. Cleanup duplicate code 

    Possible since last fix
    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c0076c5 View commit details
    Browse the repository at this point in the history

  6. Fix height of ScrollArea 

    The height of the horizontal scrollbar is already taken care of by
Scrollable. So it sohuld not be part of the height calculation.

The calculation got messed up, when ScrollbarSize != 1 indicating the
old calculations were wrong already.
    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cf5518f View commit details
    Browse the repository at this point in the history

  7. Remove the scrollbar highlighting when clicked 

    It does not 'de-highlight' and it was only active for the Summary view
(making it more consistent with the rest of YAFC)
    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e1cd68e View commit details
    Browse the repository at this point in the history

  8. Scroll down/up exactly one page with page down/up keys

    @veger
    veger committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4a8c135 View commit details
    Browse the repository at this point in the history