Fix 5676ce7a, where returning to the Welcome screen and opening a project again could break panels in the main window. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect again could break panels in the main window.
shpaass
approved these changes
Jun 15, 2024
|
Any idea why it could've happened? Were the instances disposed of? |
|
Each Instance gets the first MainScreen's InputSystem, and continues to interact with that system even after the new InputSystem is created for the second MainScreen. Recreating the PseudoScreens every time forces them to reread MainScreen.Instance.InputSystem, and interact with the current system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce this, open the Milestones Editor, NEI Explorer, Preferences screen, a single-object selection screen (the full list of fuels or modules is most likely), the Shopping list, the module customization screen, or the module templates screen. Then select "Return to starting screen" from the main menu, load or create any project, and try to interact with any screen you previously opened.
<Escape> and maybe <Enter> will work, but mouse interaction will not work.