Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard and right-click shortcuts #154

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Jun 13, 2024

This closes #35 by adding the Enter/Return, right-click, and Ctrl+T behaviors mentioned there. It also adds right-click on products and ingredients to remove or create ordinary links (by asking "What can we clear when right-clicking on an ingredient?"), and right-click on desired products to remove and unlink them.

I'll admit I'm not a fan of 5676ce7, but I was unable to figure out how to get a single InputSystem to send Enter to the correct window when multiple OS windows were open.

@shpaass
Copy link
Owner

shpaass commented Jun 13, 2024

This is awesome. Thank you for implementing this! I will check it out in 10 hours.

@shpaass
Copy link
Owner

shpaass commented Jun 13, 2024

Checked the basic functionality of Enter, Ctrl+T, and Right Mouse Button -- things work as expected.

Copy link
Owner

@shpaass shpaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @veger to resolve the conversation.

@shpaass shpaass merged commit 270b776 into shpaass:master Jun 14, 2024
1 check passed
@DaleStan DaleStan deleted the add-shortcuts-35 branch June 14, 2024 15:41
shpaass added a commit that referenced this pull request Jul 17, 2024
This fixes #192, and may or may not improve #154.

It reverts 5676ce7 (which I didn't like, but couldn't fix at the time)
and the commits that depend on it, and then re-implements ef55b5e in a
way that doesn't require 5676ce7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shortcuts
3 participants