Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot placeable is accessible #132

Merged
merged 2 commits into from
May 16, 2024

Conversation

DaleStan
Copy link
Collaborator

From ShadowTheAge#191:

This makes bot-placeable (script-created but blueprintable) entities accessible, such as the rod/plate/gear casters from Industrial Revolution. Making the casters accessible also makes the recipes used by those casters accessible.

For recipe accessibility it's only important for crafters, but it also reduces the chances of false positive warnings related to things like the 1-to-N underground pipes in Advanced Fluid Handling.

This also updates the shopping list to show the Metal cast items instead of listing the Plate cast, Rod cast, Gear cast, and Ingot cast entities separately.

This makes script-replaced entities accessible, such as the underground pipes from Advanced Fluid Handling (meh) and the rod/plate/gear casters from IR (also makes the recipes tied those casters accessible).
@shpaass
Copy link
Owner

shpaass commented May 16, 2024

I receive the following error when loading an existing PyAE project from your branch:
grafik

The error is also present in the master branch of your fork. The error is not present in the master of this fork.
Perhaps I tested the wrong way. I'll test it in the current fork.

@shpaass
Copy link
Owner

shpaass commented May 16, 2024

Yup, I tested the wrong thing. The PR branch launches successfully. It was my mistake to test the branch from your fork.

@shpaass
Copy link
Owner

shpaass commented May 16, 2024

Does anyone have the mods in question to test the new functionality?

Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks good to me, I don't have IR to test with

@shpaass shpaass merged commit 70b8761 into shpaass:master May 16, 2024
1 check passed
@DaleStan DaleStan deleted the bot-placeable-is-accessible-ce branch May 17, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants