Fix ShadowTheAge#224, where long milestone names could hide remove buttons. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttons. Set a maximum width for names in the milestone editor, and then increase the width of the milestone editor so that limit isn't reached in the example case.
shpaass
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a maximum width for names in the milestone editor, and then increase the width of the milestone editor so that limit isn't reached in the example case.
This is the object with the longest Russian name I found in Exotic Industries, so that's what I tested with. The first (and more complicated) fix squishes the text horizontally into the available space, as shown in the second screenshot. The second fix, which is the
base(50)call, expands the available space (third screenshot) so we hopefully won't often need the first fix.