Auto-assign beacons to recipes before modules. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Props for checking the compatibility with other PRs. |
|
Apologies for updating the branch with a merge commit -- that was a missclick. Feel free to remove it and update the branch by rebase. One thing that I would ask you to add to the commit message is the example of what the change fixes. Currently, it describes the general situation but gives no concrete usecase. A concrete usecase would help to quckly grasp the reason for the fix. |
This way, effectivity modules will fill to the limit or to the point of counteracting the beacons' effects, rather than stopping at 80% of the 0-beacon consumption.
shpaass
force-pushed
the
fix-auto-effectivity-ce
branch
from
8267d25
to
34a23e0
Compare
|
Doing it now |
shpaass
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, effectivity modules will fill to the limit or to the point of counteracting the beacons' effects, rather than stopping at 80% of the 0-beacon consumption.
In the attached IR3 yafc file (save also attached) the original behavior incorrectly auto-assigned two EFF 3 modules to the recipe, when it should have received four. The recipe should get four modules because there are four speed beacons also affecting the building, substantially increasing its consumption. Switching the order to assign beacons first causes the EFF modules to get auto-added correctly.
IR test.zip
IR3 game.zip
(This is rebased from ShadowTheAge#201)
It doesn't appear to matter whether this change is based on master or more-code-cleanup, so I based on master, to make it easier to merge it when/wherever. If you'd prefer I rebase it, let me know.